Skip to content

Fixed odd naming suggestions#59674

Merged
CyrusNajmabadi merged 9 commits intodotnet:mainfrom
DoctorKrolic:fix-naming-suggestions
Feb 27, 2022
Merged

Fixed odd naming suggestions#59674
CyrusNajmabadi merged 9 commits intodotnet:mainfrom
DoctorKrolic:fix-naming-suggestions

Conversation

@DoctorKrolic
Copy link
Copy Markdown
Contributor

@DoctorKrolic DoctorKrolic commented Feb 20, 2022 •
edited
Loading

Fixes: #36364

  1. Fixes wrong naming suggestion for collections of basic types, like IEnumerable<string>
  2. Improves naming suggestion for generics, e.g. IEnumerable<T> -> values, IEnumerable<TResult> -> results, IEnumerable<TParam> -> @params

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner February 20, 2022 18:36
@ghost ghost added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-IDE labels Feb 20, 2022
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

CyrusNajmabadi commented Feb 24, 2022

Looks awesome. Thanks!

@DoctorKrolic
Copy link
Copy Markdown
Contributor Author

DoctorKrolic commented Feb 25, 2022

I suppose, auto-merge is blocked here, because 1 of required CI checks failed. However, I think that I am not responsible for it, or am I?

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

CyrusNajmabadi commented Feb 25, 2022

You are not. We'll shepherd this in.

@CyrusNajmabadi CyrusNajmabadi merged commit f494b56 into dotnet:main Feb 27, 2022
@ghost ghost added this to the Next milestone Feb 27, 2022
@DoctorKrolic DoctorKrolic deleted the fix-naming-suggestions branch February 27, 2022 09:58
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier left review comments

+1 more reviewer

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

17.2.P2

Development

Successfully merging this pull request may close these issues.

Odd suggested parameter names in some cases

5 participants

@DoctorKrolic @CyrusNajmabadi @davidwengier @RikkiGibson @jinujoseph