Skip to content

Make IdeAnalyzerOptions global#59657

Merged
tmat merged 4 commits intodotnet:mainfrom
tmat:GlobalIdeAnalyzerOptions
Mar 13, 2022
Merged

Make IdeAnalyzerOptions global#59657
tmat merged 4 commits intodotnet:mainfrom
tmat:GlobalIdeAnalyzerOptions

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Feb 18, 2022

When caching a compilation with analyzers in DiagnosticIncrementalAnalyzer account for the value of IdeAnalyzerOptions since the DiagnosticIncrementalAnalyzer indirectly depends on them.

@ghost ghost added the Area-IDE label Feb 18, 2022
@tmat tmat force-pushed the GlobalIdeAnalyzerOptions branch 3 times, most recently from ca4be0f to 5b49b98 Compare February 23, 2022 18:24
@tmat tmat changed the title Global ide analyzer options Make IdeAnalyzerOptions global Feb 23, 2022
@tmat tmat marked this pull request as ready for review February 23, 2022 18:44
@tmat tmat requested review from a team as code owners February 23, 2022 18:44
@tmat tmat requested a review from a team February 23, 2022 18:44
@tmat tmat force-pushed the GlobalIdeAnalyzerOptions branch 2 times, most recently from 0a08183 to 024b4dc Compare February 25, 2022 18:46
@tmat tmat force-pushed the GlobalIdeAnalyzerOptions branch from 024b4dc to 895dea2 Compare March 7, 2022 19:10
@tmat tmat force-pushed the GlobalIdeAnalyzerOptions branch from 895dea2 to 65e1e22 Compare March 8, 2022 20:10
Copy link
Copy Markdown
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Mar 10, 2022

/azp run roslyn-integration-CI

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@tmat tmat force-pushed the GlobalIdeAnalyzerOptions branch from 65e1e22 to 4514640 Compare March 11, 2022 20:09
@tmat tmat merged commit bd52e9e into dotnet:main Mar 13, 2022
@ghost ghost added this to the Next milestone Mar 13, 2022
@tmat tmat deleted the GlobalIdeAnalyzerOptions branch March 13, 2022 06:08
@allisonchou allisonchou removed this from the Next milestone Mar 28, 2022
@allisonchou allisonchou added this to the 17.2.P3 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants