Skip to content

Add feature to fixup code when user transposes 'record' in a declaration#59652

Merged
CyrusNajmabadi merged 5 commits intodotnet:mainfrom
CyrusNajmabadi:offerToSwapMisplacedKeyword
Mar 1, 2022
Merged

Add feature to fixup code when user transposes 'record' in a declaration#59652
CyrusNajmabadi merged 5 commits intodotnet:mainfrom
CyrusNajmabadi:offerToSwapMisplacedKeyword

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

@CyrusNajmabadi CyrusNajmabadi commented Feb 18, 2022

Followup to #59622

Looks like:

image

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners February 18, 2022 20:37
@ghost ghost added the Area-Compilers label Feb 18, 2022
Copy link
Copy Markdown
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDE bits make sense, though I think the fixer name should change.

@davidwengier
Copy link
Copy Markdown
Member

Very nice :)

@jcouv jcouv force-pushed the offerToSwapMisplacedKeyword branch from 1df28cc to a1dd95c Compare March 1, 2022 18:29
@jcouv
Copy link
Copy Markdown
Member

jcouv commented Mar 1, 2022

Rebased since #59622 was just merged/squashed. It went smoothly (did git rebase -i dotnet/main and just deleted the first four commits from that previous PR; merges didn't cause any issues).
I verified things still build.

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge March 1, 2022 19:38
@CyrusNajmabadi CyrusNajmabadi merged commit 53b34d4 into dotnet:main Mar 1, 2022
@ghost ghost added this to the Next milestone Mar 1, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the offerToSwapMisplacedKeyword branch March 2, 2022 22:11
@allisonchou allisonchou modified the milestones: Next, 17.2.P3 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants