Skip to content

NavigationOptions refactoring#59505

Merged
tmat merged 2 commits intodotnet:mainfrom
tmat:NavigationOptions
Feb 12, 2022
Merged

NavigationOptions refactoring#59505
tmat merged 2 commits intodotnet:mainfrom
tmat:NavigationOptions

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Feb 11, 2022 •
edited
Loading

Validate builds:

  • TypeScript
  • F#

@tmat tmat requested review from a team as code owners February 11, 2022 21:51
@tmat tmat requested a review from a team February 11, 2022 21:51
@ghost ghost added the Area-IDE label Feb 11, 2022
@tmat tmat force-pushed the NavigationOptions branch from 1fa7bbf to f4090ad Compare February 11, 2022 22:49
@tmat tmat force-pushed the NavigationOptions branch from f4090ad to 5d5028d Compare February 11, 2022 23:00
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Feb 11, 2022 •
edited
Loading

@JoeRobich Added another commit to fix up TypeScript. Had to try a few approaches. Should be final now.

@tmat tmat enabled auto-merge (squash) February 11, 2022 23:35
@tmat tmat mentioned this pull request Feb 11, 2022
Draft
2 tasks
CyrusNajmabadi
CyrusNajmabadi approved these changes Feb 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as long as partners are looped into how respond gently on their end.

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Feb 11, 2022

Yes, TS and F# are being handled.

@tmat tmat merged commit 7736cf2 into dotnet:main Feb 12, 2022
@ghost ghost added this to the Next milestone Feb 12, 2022
@runfoapp runfoapp bot mentioned this pull request Feb 14, 2022
Open
@tmat tmat deleted the NavigationOptions branch February 15, 2022 03:04
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

+1 more reviewer

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE

Projects

None yet

Milestone

17.2.P2

Development

Successfully merging this pull request may close these issues.

4 participants

@tmat @JoeRobich @CyrusNajmabadi @RikkiGibson