Add a few asserts/throws to our CodeModel implementation#59500
Merged
jasonmalinowski merged 2 commits intodotnet:mainfrom Feb 11, 2022
Merged
Conversation
ryzngard
reviewed
Feb 11, 2022
a67edef to
ba4d350
Compare
We had a case where a workspace change during the middle of a CodeModel operation meant that this replace might throw not-obvious exceptions later when we tried to reformat the tree.
ba4d350 to
b269e9c
Compare
ryzngard
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging some CodeModel issues yesterday, these would have greatly simplified the investigation. Just adding these now before I forget them and while we figure out how to properly fix the issues.