Skip to content

Only subscribe to ActiveDocumentChanged if solution cralwer is enabled#59498

Merged
RikkiGibson merged 1 commit intodotnet:mainfrom
mavasani:FixRpsRegression
Feb 12, 2022
Merged

Only subscribe to ActiveDocumentChanged if solution cralwer is enabled#59498
RikkiGibson merged 1 commit intodotnet:mainfrom
mavasani:FixRpsRegression

Conversation

@mavasani
Copy link
Copy Markdown
Contributor

@mavasani mavasani commented Feb 11, 2022 •
edited by RikkiGibson
Loading

Attempts to fix the RPS regression pointed out in #59492

RPS Validation Pipeline PR for this change

@mavasani mavasani requested a review from a team as a code owner February 11, 2022 20:20
@mavasani mavasani mentioned this pull request Feb 11, 2022
Closed
@RikkiGibson RikkiGibson self-assigned this Feb 11, 2022
@sharwell
Copy link
Copy Markdown
Contributor

sharwell commented Feb 12, 2022

OOP .NET Core is showing gold bars in integration tests (not caused by this PR):

Feature 'Edit and Continue' is currently unavailable due to an internal error.
StreamJsonRpc.RemoteInvocationException: Failed to deserialize: PreferIsNotExpression-VisualBasicCodeStyleOptions-False-
   at StreamJsonRpc.JsonRpc.<InvokeCoreAsync>d__143`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable.ConfiguredValueTaskAwaiter.GetResult()
   at Microsoft.CodeAnalysis.Remote.BrokeredServiceConnection`1.<TryInvokeAsync>d__15.MoveNext() in /_/src/Workspaces/Remote/Core/BrokeredServiceConnection.cs:line 168
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)
RPC server exception:
System.InvalidOperationException: Failed to deserialize: PreferIsNotExpression-VisualBasicCodeStyleOptions-False-
      at Microsoft.CodeAnalysis.Remote.ThrowingTraceListener.Fail(String message, String detailMessage) in /_/src/Workspaces/Remote/ServiceHub/Host/ThrowingTraceListener.cs:line 24
      at System.Diagnostics.TraceInternal.Fail(String message, String detailMessage)
      at System.Diagnostics.TraceInternal.TraceProvider.Fail(String message, String detailMessage)
      at System.Diagnostics.Debug.Fail(String message, String detailMessage)
      at System.Diagnostics.Debug.Fail(String message)
      at Microsoft.CodeAnalysis.Options.SerializableOptionSet.<Deserialize>g__TryDeserializeOptionKey|16_1(ObjectReader reader, ILookup`2 lookup) in /_/src/Workspaces/Core/Portable/Options/SerializableOptionSet.cs:line 469
      at Microsoft.CodeAnalysis.Options.SerializableOptionSet.Deserialize(ObjectReader reader, IOptionService optionService, CancellationToken cancellationToken) in /_/src/Workspaces/Core/Portable/Options/SerializableOptionSet.cs:line 380
      at Microsoft.CodeAnalysis.Serialization.SerializerService.DeserializeOptionSet(ObjectReader reader, CancellationToken cancellationToken) in /_/src/Workspaces/Core/Portable/Serialization/SerializerService_OptionSet.cs:line 25
      at Microsoft.CodeAnalysis.Serialization.SerializerService.Deserialize[T](WellKnownSynchronizationKind kind, ObjectReader reader, CancellationToken cancellationToken) in /_/src/Workspaces/Core/Portable/Serialization/SerializerService.cs:line 213
      at Microsoft.CodeAnalysis.Remote.RemoteHostAssetSerialization.ReadData(Stream stream, Int32 scopeId, ISet`1 checksums, ISerializerService serializerService, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/Core/RemoteHostAssetSerialization.cs:line 172
      at Microsoft.CodeAnalysis.Remote.RemoteHostAssetSerialization.ReadDataAsync(PipeReader pipeReader, Int32 scopeId, ISet`1 checksums, ISerializerService serializerService, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/Core/RemoteHostAssetSerialization.cs:line 111
      at Microsoft.CodeAnalysis.Remote.RemoteHostAssetSerialization.ReadDataAsync(PipeReader pipeReader, Int32 scopeId, ISet`1 checksums, ISerializerService serializerService, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/Core/RemoteHostAssetSerialization.cs:line 124
      at Microsoft.CodeAnalysis.Remote.BrokeredServiceConnection`1.<>c__DisplayClass26_0`1.<<InvokeStreamingServiceAsync>b__1>d.MoveNext() in /_/src/Workspaces/Remote/Core/BrokeredServiceConnection.cs:line 422
   --- End of stack trace from previous location ---
      at Microsoft.CodeAnalysis.Remote.BrokeredServiceConnection`1.<>c__DisplayClass26_0`1.<<InvokeStreamingServiceAsync>b__1>d.MoveNext() in /_/src/Workspaces/Remote/Core/BrokeredServiceConnection.cs:line 431
   --- End of stack trace from previous location ---
      at Microsoft.CodeAnalysis.Remote.BrokeredServiceConnection`1.InvokeStreamingServiceAsync[TResult](TService service, Func`4 invocation, Func`3 reader, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/Core/BrokeredServiceConnection.cs:line 434
      at Microsoft.CodeAnalysis.Remote.RemoteCallback`1.InvokeAsync[TResult](Func`4 invocation, Func`3 reader, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/Core/RemoteCallback.cs:line 68
      at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)
   --- End of stack trace from previous location ---
      at Microsoft.CodeAnalysis.Remote.SolutionAssetSource.GetAssetsAsync(Int32 scopeId, ISet`1 checksums, ISerializerService serializerService, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/ServiceHub/Host/SolutionAssetSource.cs:line 34
      at Microsoft.CodeAnalysis.Remote.AssetProvider.RequestAssetsAsync(ISet`1 checksums, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/ServiceHub/Host/AssetProvider.cs:line 162
      at Microsoft.CodeAnalysis.Remote.AssetProvider.SynchronizeAssetsAsync(ISet`1 checksums, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/ServiceHub/Host/AssetProvider.cs:line 133
      at Microsoft.CodeAnalysis.Remote.ChecksumSynchronizer.SynchronizeAssets_NoLockAsync(IEnumerable`1 checksumOrCollections, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/ServiceHub/Host/ChecksumSynchronizer.cs:line 95
      at Microsoft.CodeAnalysis.Remote.ChecksumSynchronizer.SynchronizeSolutionAssetsAsync(Checksum solutionChecksum, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/ServiceHub/Host/ChecksumSynchronizer.cs:line 42
      at Microsoft.CodeAnalysis.Remote.AssetProvider.SynchronizeSolutionAssetsAsync(Checksum solutionChecksum, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/ServiceHub/Host/AssetProvider.cs:line 88
      at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.CreateFullSolution_NoLockAsync(AssetProvider assetProvider, Checksum solutionChecksum, Boolean fromPrimaryBranch, Int32 workspaceVersion, Solution baseSolution, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace.cs:line 192
      at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.GetFullSolutionAsync(AssetProvider assetProvider, Checksum solutionChecksum, Boolean fromPrimaryBranch, Int32 workspaceVersion, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace.cs:line 128
      at Microsoft.CodeAnalysis.EditAndContinue.RemoteEditAndContinueService.<>c__DisplayClass18_0.<<OnSourceFileUpdatedAsync>b__0>d.MoveNext() in /_/src/Workspaces/Remote/ServiceHub/Services/EditAndContinue/RemoteEditAndContinueService.cs:line 240
   --- End of stack trace from previous location ---
      at Microsoft.CodeAnalysis.Remote.BrokeredServiceBase.RunServiceImplAsync(Func`2 implementation, CancellationToken cancellationToken) in /_/src/Workspaces/Remote/ServiceHub/Services/BrokeredServiceBase.cs:line 119

@RikkiGibson
Copy link
Copy Markdown
Member

RikkiGibson commented Feb 12, 2022

Merging to expedite unblocking the build.

@RikkiGibson RikkiGibson merged commit 0a02742 into dotnet:main Feb 12, 2022
@ghost ghost added this to the Next milestone Feb 12, 2022
@mavasani mavasani deleted the FixRpsRegression branch February 12, 2022 03:30
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

+1 more reviewer

@sharwell sharwell sharwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RikkiGibson RikkiGibson

Labels

Area-IDE

Projects

None yet

Milestone

17.2.P2

Development

Successfully merging this pull request may close these issues.

3 participants

@mavasani @sharwell @RikkiGibson