Skip to content

Fix a few issues with use object/collection initializer.#59479

Merged
CyrusNajmabadi merged 5 commits intodotnet:mainfrom
CyrusNajmabadi:useInitializeBaseObject
Feb 11, 2022
Merged

Fix a few issues with use object/collection initializer.#59479
CyrusNajmabadi merged 5 commits intodotnet:mainfrom
CyrusNajmabadi:useInitializeBaseObject

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

Fixes #47632

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner February 11, 2022 08:02
@ghost ghost added the Area-IDE label Feb 11, 2022
static void M()
{
List<object> items = [|new|] List<object>();
items[0] = 1;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want a no diagnostic test where this line is not present to match the original repro case in the issue being fixed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, i can def add that :)

@CyrusNajmabadi CyrusNajmabadi merged commit e103096 into dotnet:main Feb 11, 2022
@ghost ghost added this to the Next milestone Feb 11, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the useInitializeBaseObject branch February 11, 2022 11:03
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IDE0028 breaks working code

4 participants