Improve 'use pattern matching' to use is null instead of is not object#59464
Merged
CyrusNajmabadi merged 6 commits intodotnet:mainfrom Feb 11, 2022
Merged
Improve 'use pattern matching' to use is null instead of is not object#59464CyrusNajmabadi merged 6 commits intodotnet:mainfrom
is null instead of is not object#59464CyrusNajmabadi merged 6 commits intodotnet:mainfrom
Conversation
sharwell
reviewed
Feb 10, 2022
Comment on lines
+130
to
+132
| [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsUseNotPattern)] | ||
| [WorkItem(50690, "https://github.com/dotnet/roslyn/issues/50690")] | ||
| public async Task BinaryIsObject() |
Contributor
There was a problem hiding this comment.
Suggested change
| [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsUseNotPattern)] | |
| [WorkItem(50690, "https://github.com/dotnet/roslyn/issues/50690")] | |
| public async Task BinaryIsObject() | |
| [Theory, CombinatorialData, Trait(Traits.Feature, Traits.Features.CodeActionsUseNotPattern)] | |
| [WorkItem(50690, "https://github.com/dotnet/roslyn/issues/50690")] | |
| public async Task BinaryIsObject([CombinatorialValues(LanguageVersion.CSharp8, LanguageVersion.CSharp9)] LanguageVersion languageVersion) |
sharwell
reviewed
Feb 10, 2022
| } | ||
| } | ||
| }", | ||
| LanguageVersion = LanguageVersion.CSharp9, |
Contributor
There was a problem hiding this comment.
Suggested change
| LanguageVersion = LanguageVersion.CSharp9, | |
| LanguageVersion = languageVersion, |
sharwell
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.