Inverting TypeOf should support 'TypeOf x IsNot...'#59460
Merged
CyrusNajmabadi merged 12 commits intodotnet:mainfrom Feb 11, 2022
Merged
Inverting TypeOf should support 'TypeOf x IsNot...'#59460CyrusNajmabadi merged 12 commits intodotnet:mainfrom
CyrusNajmabadi merged 12 commits intodotnet:mainfrom
Conversation
sharwell
reviewed
Feb 10, 2022
src/EditorFeatures/CSharpTest/InvertIf/InvertIfTests.Elseless.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Feb 10, 2022
src/EditorFeatures/CSharpTest/InvertIf/InvertIfTests.Elseless.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Feb 10, 2022
src/EditorFeatures/CSharpTest/InvertIf/InvertIfTests.Elseless.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@sharwell i have a followup PR to our other features to improve those scenarios :) |
Contributor
Author
|
@sharwell this is ready for rereview. |
davidwengier
approved these changes
Feb 11, 2022
...s/SharedUtilitiesAndExtensions/Workspace/Core/Extensions/SyntaxGeneratorExtensions_Negate.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51359