'Add selected parameters to constructor' should respect existing user formatting#59432
Merged
CyrusNajmabadi merged 9 commits intodotnet:mainfrom Feb 11, 2022
Merged
'Add selected parameters to constructor' should respect existing user formatting#59432CyrusNajmabadi merged 9 commits intodotnet:mainfrom
CyrusNajmabadi merged 9 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Feb 9, 2022
| return newParameterSymbol; | ||
| } | ||
|
|
||
| private static void AddParameter( |
Contributor
Author
There was a problem hiding this comment.
moved to common location
CyrusNajmabadi
commented
Feb 9, 2022
|
|
||
| namespace Microsoft.CodeAnalysis.AddParameter | ||
| { | ||
| internal interface IAddParameterService |
Contributor
Author
There was a problem hiding this comment.
no purpose in an interface here to expose entirely static helpers.
CyrusNajmabadi
commented
Feb 9, 2022
| { | ||
| internal static class AddParameterEditor | ||
| { | ||
| public static void AddParameter( |
Contributor
Author
There was a problem hiding this comment.
this is a move. nothing was changed with the logic in this.
CyrusNajmabadi
commented
Feb 9, 2022
| Document invocationDocument, | ||
| IMethodSymbol method, | ||
| ITypeSymbol newParamaterType, | ||
| ITypeSymbol newParameterType, |
CyrusNajmabadi
commented
Feb 9, 2022
| { | ||
| var currentParameterList = destination.GetParameterList(); | ||
|
|
||
| if (currentParameterList == null) |
Contributor
Author
There was a problem hiding this comment.
this is the thrust of the change. instead of directly adding hte new parameters to the method syntax here, we instead call through teh helper service which will properly wrap/indent them.
Contributor
Author
There was a problem hiding this comment.
the same change happens for VB below
davidwengier
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58040
Fixes #49040
Note: the 'add parameter from callsite' feature already supported this. I've extracted the actual parameter adding code to a common location that can then be used by both features to have consistent behavior.