Simplify the wrapping code for initializer-expression wrapping#59397
Merged
CyrusNajmabadi merged 15 commits intodotnet:mainfrom Feb 14, 2022
Merged
Simplify the wrapping code for initializer-expression wrapping#59397CyrusNajmabadi merged 15 commits intodotnet:mainfrom
CyrusNajmabadi merged 15 commits intodotnet:mainfrom
Conversation
8fb9f2c to
e4f5b2c
Compare
431fd7f to
9a2de5a
Compare
Contributor
Author
|
@sharwell this is ready to rereview. |
Contributor
Author
CyrusNajmabadi
commented
Feb 13, 2022
| { | ||
| internal abstract partial class AbstractSeparatedListWrapper<TListSyntax, TListItemSyntax> | ||
| { | ||
| protected abstract class AbstractSeparatedListCodeComputer<TWrapper> : AbstractCodeActionComputer<TWrapper> |
Contributor
Author
There was a problem hiding this comment.
this code just moved back into AbstractSeparatedListWrapper
CyrusNajmabadi
commented
Feb 13, 2022
| protected sealed override ImmutableArray<Edit> GetWrapEachEdits( | ||
| WrappingStyle wrappingStyle, SyntaxTrivia indentationTrivia) | ||
| { | ||
| using var _ = ArrayBuilder<Edit>.GetInstance(out var result); |
Contributor
Author
There was a problem hiding this comment.
all this logic was basically teh same as normal separated wrapping, just with some tweaks about how hte start/end brace are handled. so this merged back into that, and that code was updated to be hte same as before, just with specialization around start/end brace.
davidwengier
approved these changes
Feb 14, 2022
Member
davidwengier
left a comment
There was a problem hiding this comment.
Assuming the absence of tests here means no behaviour change
Contributor
Author
Yup. It was just a simplification refactoring |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #39878