Cascade between position record parameters and properties.#59293
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Feb 7, 2022
Merged
Cascade between position record parameters and properties.#59293CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Conversation
RikkiGibson
reviewed
Feb 4, 2022
src/EditorFeatures/Test2/FindReferences/FindReferencesTests.ParameterSymbol.vb
Show resolved
Hide resolved
Member
|
Talking offline, we think it would be ideal for the compiler to expose public APIs which let the IDE do the right thing here for both source and metadata scenarios. For example, if a record var rec = new Rec(param: 1); // find-all-refs on "param" here
_ = rec.param.M(); // should include 'param' in resultsI'm going to take a stab at coming up with public API that would address the scenario and we can bring it to API review. |
davidwengier
approved these changes
Feb 7, 2022
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44559