Add support for decoding required members in metadata#59288
Merged
333fred merged 3 commits intodotnet:features/required-membersfrom Feb 15, 2022
Merged
Add support for decoding required members in metadata#59288333fred merged 3 commits intodotnet:features/required-membersfrom
333fred merged 3 commits intodotnet:features/required-membersfrom
Conversation
Added support for reading the RequiredMemberAttribute from metadata appropriately and returning the right result for IsRequired and HasDeclaredRequiredMembers for metadata infos.
RikkiGibson
approved these changes
Feb 10, 2022
src/Compilers/CSharp/Test/Symbol/Symbols/RequiredMembersTests.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Feb 11, 2022
src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PEFieldSymbol.cs
Outdated
Show resolved
Hide resolved
jcouv
approved these changes
Feb 11, 2022
Member
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks (iteration 1) with a nit to consider
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for reading the RequiredMemberAttribute from metadata appropriately and returning the right result for IsRequired and HasDeclaredRequiredMembers for metadata infos.
Test plan: #57046