Always allow the 'upgrade project' fixer to upgrade to 'preview' versions of C##59248
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Feb 3, 2022
Merged
Conversation
CyrusNajmabadi
commented
Feb 3, 2022
| // how well they work, while also explicitly putting them into a *know* unsupported state (that's what | ||
| // preview is after all). Importantly, this doesn't put them into an unrealized unsupported state (for | ||
| // example, picking some combo of a real lang version that isn't supported with their chosen framework | ||
| // version). |
Contributor
Author
There was a problem hiding this comment.
if anyone has a cleaner way of saying the above. please LMK :)
CyrusNajmabadi
commented
Feb 3, 2022
src/VisualStudio/CSharp/Impl/Utilities/CSharpParseOptionsChangingService.cs
Outdated
Show resolved
Hide resolved
dibarbet
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58742