Move embedded language tests to unittests2 project#59235
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Feb 3, 2022
Merged
Move embedded language tests to unittests2 project#59235CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
Conversation
davidwengier
approved these changes
Feb 3, 2022
ryzngard
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are over 20,000 tests currently for regex/json. This amount actually doubles the amount of time that test dicovery takes in Microsoft.CodeAnalysis.CSharp.EditorFeatures.UnitTests. To help mitigate this, i've moved them to the unittests2 project (which is where all the keyword recommender tests were placed for a similar reason). This project is touched far less, and humongo test suites like these can be placed here without affecting the far more commonly used Microsoft.CodeAnalysis.CSharp.EditorFeatures.UnitTests projecrt (where we have all the code-style/diagnostics/fixers/refactoring tests).