Allow full source from metadata and decompilation in LSP#59217
Merged
davidwengier merged 1 commit intodotnet:mainfrom Feb 2, 2022
Merged
Allow full source from metadata and decompilation in LSP#59217davidwengier merged 1 commit intodotnet:mainfrom
davidwengier merged 1 commit intodotnet:mainfrom
Conversation
dibarbet
approved these changes
Feb 2, 2022
dibarbet
reviewed
Feb 2, 2022
| if (!typeOnly || symbol is ITypeSymbol) | ||
| { | ||
| var declarationFile = await _metadataAsSourceFileService.GetGeneratedFileAsync(document.Project, symbol, signaturesOnly: true, allowDecompilation: false, cancellationToken).ConfigureAwait(false); | ||
| var declarationFile = await _metadataAsSourceFileService.GetGeneratedFileAsync(document.Project, symbol, signaturesOnly: false, allowDecompilation: true, cancellationToken).ConfigureAwait(false); |
Member
There was a problem hiding this comment.
Just remembered - should we instead pass the 'navigate to decompiled source option' here?
Member
Author
There was a problem hiding this comment.
The decompilation service checks that internally, and ignores the allowDecompilation parameter if the option is off.
JoeRobich
approved these changes
Feb 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58702
I set this wrong when I expanded from one
allowDecompilationparameter here, to two.