Revert "Clean up diagnostic and solution crawler options (#59083)"#59198
Merged
JoeRobich merged 2 commits intodotnet:mainfrom Feb 1, 2022
Merged
Revert "Clean up diagnostic and solution crawler options (#59083)"#59198JoeRobich merged 2 commits intodotnet:mainfrom
JoeRobich merged 2 commits intodotnet:mainfrom
Conversation
This reverts commit 5f8657a.
333fred
commented
Feb 1, 2022
src/VisualStudio/VisualStudioDiagnosticsToolWindow/VisualStudioDiagnosticsWindowPackage.cs
Show resolved
Hide resolved
333fred
commented
Feb 1, 2022
| public static readonly Option2<DiagnosticMode> NormalDiagnosticMode = new(nameof(InternalDiagnosticsOptions), nameof(NormalDiagnosticMode), defaultValue: DiagnosticMode.Default, | ||
| storageLocation: new LocalUserProfileStorageLocation(LocalRegistryPath + "NormalDiagnosticMode")); | ||
|
|
||
| public static readonly Option2<bool> EnableFileLoggingForDiagnostics = new(nameof(InternalDiagnosticsOptions), nameof(EnableFileLoggingForDiagnostics), defaultValue: false, |
Member
Author
There was a problem hiding this comment.
This had to be manually merged, as the original commit still had RazorDiagnosticMode, but the upstream had removed it since that commit.
genlu
approved these changes
Feb 1, 2022
RikkiGibson
approved these changes
Feb 1, 2022
tmat
approved these changes
Feb 1, 2022
Member
|
Merging to unblock signed builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5f8657a.