Validate Microsoft.CodeAnalysis.Collections.Package on net6.0#59187
Merged
sharwell merged 1 commit intodotnet:mainfrom Feb 7, 2022
Merged
Validate Microsoft.CodeAnalysis.Collections.Package on net6.0#59187sharwell merged 1 commit intodotnet:mainfrom
sharwell merged 1 commit intodotnet:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
@sharwell you need to update the exclusions to include the new TF. Example is here These exclusions exist because the .csproj files for our source NuPkg use the following <DebugType>none</DebugType>The rebuild leg requires a PDB (embedded or on disk) in order to execute the rebuild logic. Lacking a PDB the DLLs must be excluded from our rebuild work. Ideally we'd just change this to have a PDB. It's unclear to me why it's explicitly turned off here. |
bfe0f80 to
d4300ee
Compare
d4300ee to
31c89f0
Compare
jaredpar
approved these changes
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #57665