Merged
Conversation
f1e9e26 to
e2e335c
Compare
src/Features/Core/Portable/Completion/CompletionOptionsMetadata.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/SignatureHelp/SignatureHelpHandler.cs
Show resolved
Hide resolved
src/Features/LanguageServer/ProtocolUnitTests/Workspaces/LspWorkspaceManagerTests.cs
Show resolved
Hide resolved
src/VisualStudio/CSharp/Impl/Options/IntelliSenseOptionPageControl.xaml.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Feb 1, 2022
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
LGTM. have some questions i'd like some clarity on just to make sure my understanding is correct.
7354476 to
882eb24
Compare
882eb24 to
39f4fab
Compare
a9cc7a2 to
7a090c9
Compare
sharwell
reviewed
Feb 4, 2022
Comment on lines
+14
to
+15
| /// TODO: Options are currently explicitly listed since <see cref="OptionKey"/> is not serializable. | ||
| /// https://github.com/dotnet/roslyn/issues/59267 |
Contributor
There was a problem hiding this comment.
💡 I recommend resolving this as won't fix. New integration tests already support OptionKey directly, and old integration tests are being actively ported to the new library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes CompletionOptions from Solution snapshot. The options are now only stored in global options.
Establishes a new pattern: Option definitions move from being nested as
XyzOptions.Metadatato a separate typeXyzOptionsStorage(CompilationOptionsStoragein this case) that also defines an extension methodGetXyzOptionsonIGlobalOptionServiceused to fetch them. This type is to be moved to client code (editor features).This completes the separation of options from their metadata and storage.
While working on this refactoring I realized that certain scenarios were broken by previous completion options changes. When 3rd party code passes OptionSet containing their custom options into our public completion APIs these options got lost and were not available to their custom CompletionProvider. This PR fixes that by passing 3rd party options through.