add all analyzers that are configured via editorconfig to code cleanup#59106
Conversation
src/VisualStudio/VisualBasic/Impl/LanguageService/VisualBasicCodeCleanupFixerDiagnosticIds.vb
Outdated
Show resolved
Hide resolved
|
How certain are we that all of these items will not produce change runtime behavior when applied? I ask because the result of this operation is likely to be difficult/impossible to review. |
src/VisualStudio/Core/Def/Implementation/CodeCleanup/CommonCodeCleanUpFixerDiagnosticIds.cs
Outdated
Show resolved
Hide resolved
sharwell
left a comment
There was a problem hiding this comment.
❓ Before moving forward with this, can you confirm the following behavior:
- Team configures a code style rule with severity hidden (or suggestion)
- User enables the code fix for (1) as part of the code cleanup profile
- User runs Code Cleanup on Solution
For the above scenario, the Code Cleanup operation should take no action, as the project is not configured to enforce consistency for the item in question.
|
Does this fix #43503 ? |
Need to understand this perspective a bit better. If the team does this:
I interpret that as saying "this is style isn't required but if you think it makes sense then apply it". An individual developer then does this
Saying "even though this is optional I am opting in to this being done". In this case not applying the code style when code cleanup is run would both
|
Don't know how relevant that is. All code fixes change semantics in some way. The assumption here is that the default code cleanup profile will not include all of these code style options but users can choose to add them if they want to. This mirrors the behavior we have had with |
dd7e51c to
ba14eed
Compare
724c0fb to
e12d172
Compare
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
e12d172 to
454552f
Compare
Fixes #58086
Fixes #50504
Fixes #43503
If a user can set a codestyle option to fail the build, and that option has a fix-all we now give the user the option to run it on code-cleanup if desired.