Allow 'ref' and 'in' parameters to be null-checked#58938
Merged
RikkiGibson merged 1 commit intodotnet:mainfrom Jan 19, 2022
Merged
Allow 'ref' and 'in' parameters to be null-checked#58938RikkiGibson merged 1 commit intodotnet:mainfrom
RikkiGibson merged 1 commit intodotnet:mainfrom
Conversation
53 tasks
Youssef1313
reviewed
Jan 19, 2022
| } | ||
|
|
||
| [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsUseIsNullCheck)] | ||
| public async Task TestOutParameter() |
Member
There was a problem hiding this comment.
It's more common that we assert the expected compiler diagnostics here, ie, remove CompilerDiagnostics = ... below.
Member
Author
There was a problem hiding this comment.
I think this is a reasonable suggestion, and would be happy to take a change that makes this happen in a follow up.
Youssef1313
reviewed
Jan 19, 2022
|
|
||
| class C | ||
| { | ||
| public C(out string s) |
Member
There was a problem hiding this comment.
Suggested change
| public C(out string s) | |
| public {|CS0177:C|}(out string s) |
Youssef1313
reviewed
Jan 19, 2022
| { | ||
| public C(out string s) | ||
| { | ||
| if (s is null) |
Member
There was a problem hiding this comment.
Suggested change
| if (s is null) | |
| if ({|CS0269:s|} is null) |
cston
approved these changes
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #36024
Related to #58699
Please take a look @cston @chsienki @CyrusNajmabadi