Skip to content

Fix ParameterSyntax.Update to account for '!!'#58912

Merged
RikkiGibson merged 2 commits intodotnet:mainfrom
Youssef1313:parametersyntax-update
Jan 18, 2022
Merged

Fix ParameterSyntax.Update to account for '!!'#58912
RikkiGibson merged 2 commits intodotnet:mainfrom
Youssef1313:parametersyntax-update

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

@Youssef1313 Youssef1313 commented Jan 18, 2022

Fixes #58597

cc @RikkiGibson

Relates to test plan #36024

@Youssef1313 Youssef1313 requested a review from a team as a code owner January 18, 2022 12:24
@ghost ghost added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-Compilers labels Jan 18, 2022
public void TestExclamationExclamationUpdate()
{
var text = "(string s!!)";
var expression = SyntaxFactory.ParseParameterList(text).Parameters[0];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expression

parameter (and newParameter below)?

@RikkiGibson RikkiGibson enabled auto-merge (squash) January 18, 2022 17:33
@RikkiGibson RikkiGibson merged commit d566086 into dotnet:main Jan 18, 2022
@ghost ghost added this to the Next milestone Jan 18, 2022
@Youssef1313 Youssef1313 deleted the parametersyntax-update branch January 18, 2022 18:11
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible bug for ParameterSyntax.Update API around exclamationExclamationToken behavior

3 participants