Merged
Conversation
ryzngard
approved these changes
Jan 14, 2022
jasonmalinowski
previously approved these changes
Jan 14, 2022
|
|
||
| private readonly UIContext? _solutionClosingContext; | ||
| private IGlobalOperationNotificationService? _notificationService; | ||
| private readonly UIContext _solutionClosingContext = UIContext.FromUIContextGuid(VSConstants.UICONTEXT.SolutionClosing_guid); |
Member
There was a problem hiding this comment.
Just to confirm this is safe to call on any thread at this point? I know in the past there's been some gotchas with this method since it'd implicitly call into COM APIs and I think those were resolved, but not able to directly find the answer.
Contributor
Author
There was a problem hiding this comment.
➡️ Since this isn't a static variable, it's effectively the same as placing it the constructor like it was previously. In the original code, it was gated behind an if check, but the service in question for that check is always present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58827