Revert "Merge pull request #57132 from CyrusNajmabadi/branchId3"#58856
Merged
CyrusNajmabadi merged 1 commit intodotnet:release/dev17.1from Jan 20, 2022
Merged
Conversation
jasonmalinowski
approved these changes
Jan 14, 2022
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Approving in that this appears to be a clean revert of the original PR (minus the small tweaks needed for adding the _workspace field back).
Comment on lines
+51
to
+60
| /// <summary> | ||
| /// Cached compile time solution corresponding to the <see cref="Workspace.PrimaryBranchId"/> | ||
| /// </summary> | ||
| private (int DesignTimeSolutionVersion, BranchId DesignTimeSolutionBranch, Solution CompileTimeSolution)? _primaryBranchCompileTimeCache; | ||
|
|
||
| /// <summary> | ||
| /// Cached compile time solution for a forked branch. This is used primarily by LSP cases where | ||
| /// we fork the workspace solution and request diagnostics for the forked solution. | ||
| /// </summary> | ||
| private (int DesignTimeSolutionVersion, BranchId DesignTimeSolutionBranch, Solution CompileTimeSolution)? _forkedBranchCompileTimeCache; |
Member
There was a problem hiding this comment.
@tmat any concern with bringing this back? I don't know if anything more recently depended upon the simpler code in some way.
Member
There was a problem hiding this comment.
I am not aware of anything. Why do we need to revert this?
Member
There was a problem hiding this comment.
Because it caused a big regression of allocation in OOP
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1426911
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 83a728a, reversing
changes made to a4ec465.