Call InitializeTelemetrySession on background thread (#58399)#58674
Merged
tmat merged 1 commit intodotnet:release/dev17.1from Jan 6, 2022
Merged
Call InitializeTelemetrySession on background thread (#58399)#58674tmat merged 1 commit intodotnet:release/dev17.1from
tmat merged 1 commit intodotnet:release/dev17.1from
Conversation
Member
Author
|
@jinujoseph For approval. |
jasonmalinowski
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #58399 from main.
Fixes AB#1449211.
InitializeTelemetrySession accessed options which triggered assembly load that caused deadlock.
As per AB#296981, the
TelemetryService.DefaultSessionproperty must be accessed on UI thread but the rest of Roslyn telemetry service initialization can be run on background thread.The change moves telemetry initialization to VisualStudioWorkspaceImpl, so that it does not depend on RoslynPackage being loaded.