Reduce the number of duplicate ProjectId instances found in OOP#58667
Merged
sharwell merged 1 commit intodotnet:mainfrom Jan 6, 2022
Merged
Reduce the number of duplicate ProjectId instances found in OOP#58667sharwell merged 1 commit intodotnet:mainfrom
sharwell merged 1 commit intodotnet:mainfrom
Conversation
CyrusNajmabadi
approved these changes
Jan 6, 2022
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Any concern about doc ids as well?
Contributor
Author
|
My concern about DocumentId is they frequently have the same ProjectId, but this pull request already fixes that case. 👍 |
genlu
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces memory usage slightly for the scenario seen in AB#1449980.