Set the default value of Combine With Indicator Margin to false#58661
Merged
sharwell merged 1 commit intodotnet:release/dev17.1from Jan 6, 2022
Conversation
davidwengier
approved these changes
Jan 6, 2022
sharwell
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#1450426
There is no good way to handle overlapping glyphs in the editor margin.
So breakpoint could overlap with inheritance margin glyph, so there is no way to set/clear the breakpoint at this time.
This behavior is known so before inheritance margin is enabled I added an option, which can move the inheritance margin glyph to our own margin.
However, many users don't know this option and feel depressed when seeing the overlapping problem.
So this PR set the default value to false in 17.1.
In the future release, also we want to find a better way to let the user could discover this option when click inheritance margin.