Upgrade Microsoft.VisualStudio.Telemetry to 16.4.22#58621
Merged
jasonmalinowski merged 2 commits intodotnet:release/dev17.1from Jan 6, 2022
Merged
Upgrade Microsoft.VisualStudio.Telemetry to 16.4.22#58621jasonmalinowski merged 2 commits intodotnet:release/dev17.1from
jasonmalinowski merged 2 commits intodotnet:release/dev17.1from
Conversation
This brings updated support for collecting heaps when faults happen. We use the VS-shipped version in-proc and our ServiceHub process that runs on .NET Framework, but we still need to upgrade this for .NET Core-based ServiceHub processes.
genlu
approved these changes
Jan 5, 2022
Member
genlu
left a comment
There was a problem hiding this comment.
approved assuming you have validated it
Member
Author
|
@genlu: I did! Was able to see the binary loading, and was even able to step in and confirm it was using the new version. |
genlu
approved these changes
Jan 5, 2022
It appears that some dependency of our MSBuild.UnitTests.csproj project is bringing in 5.0.0 of System.Drawing.Common, while the 6.0 SDK is referencing binaries that reference 6.0.0 of System.Drawing.Common, without carrying a proper reference to the 6.0.0 NuGet package. MSBuild can't resolve that, but adding an explicit reference to 6.0.0 of System.Drawing.Common fixes that. Upgrading to System.Drawing.Common then causes the platform analyzers to realize that we're calling a Windows-only API on a cross-platform DLL. We use HasValidFonts to work around a bug in some of our old CI infrastructure, but the only place it's already used is already restricted to Windows only, so we can just duplicate that check to make everything happy again.
10731e3 to
1d913f3
Compare
333fred
approved these changes
Jan 6, 2022
Member
333fred
left a comment
There was a problem hiding this comment.
The word Jenkins brings me terror.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings updated support for collecting heaps when faults happen. We use the VS-shipped version in-proc and our ServiceHub process that runs on .NET Framework, but we still need to upgrade this for .NET Core-based ServiceHub processes.