Merged
Conversation
333fred
approved these changes
Jan 4, 2022
cston
reviewed
Jan 4, 2022
| } | ||
|
|
||
| [Fact] | ||
| public void WhitespaceInDefine() |
Contributor
Contributor
There was a problem hiding this comment.
Consider testing TrimStart() with a string that contains only spaces, and with an empty string.
Member
Author
There was a problem hiding this comment.
I considered direct testing, but it's not what we commonly do for internal APIs. We typically verify bugs via their impact on public APIs.
Added a test with only spaces.
For define: with an empty string, that is already covered by test InvalidDefineSwitch.
cston
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58074