HeapOrReferenceIndexBase.Add - immediately reserve the slot to be resilient to a re-entrancy#58526
Merged
AlekseyTs merged 2 commits intodotnet:mainfrom Dec 30, 2021
Merged
HeapOrReferenceIndexBase.Add - immediately reserve the slot to be resilient to a re-entrancy#58526AlekseyTs merged 2 commits intodotnet:mainfrom
AlekseyTs merged 2 commits intodotnet:mainfrom
Conversation
…ilient to re-entrancy Comparisons performed by dictionaries can cause re-entrancy and invalidate the index unless we reserve it before that. Fixes dotnet#58520.
333fred
reviewed
Dec 29, 2021
333fred
approved these changes
Dec 29, 2021
Member
333fred
left a comment
There was a problem hiding this comment.
LGTM (commit 1), assuming the answer to my question is yes.
cston
approved these changes
Dec 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparisons performed by dictionaries can cause a re-entrancy and invalidate the index, unless we reserve it before that.
Fixes #58520.