Stack Trace Explorer improvements#58458
Conversation
davidwengier
left a comment
There was a problem hiding this comment.
I skipped reviewing the xaml files since I have nothing to contribute. Curious what the scenario is for clear vs close? Or is clear actually "Close All"?
src/VisualStudio/Core/Def/StackTraceExplorer/StackTraceExplorerCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/StackTraceExplorer/StackTraceExplorerToolWindow.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/StackTraceExplorer/StackTraceExplorerRoot.xaml
Outdated
Show resolved
Hide resolved
davidwengier
left a comment
There was a problem hiding this comment.
I'm not sure I'm convinced the Clear button is necessary, versus just closing a tab, but it's up to you.
| <data name="Prefer_extended_property_pattern" xml:space="preserve"> | ||
| <value>Prefer extended property pattern</value> | ||
| </data> | ||
| <data name="String1" xml:space="preserve"> |
| <value>Sort usings</value> | ||
| </data> | ||
| <data name="Automatically_open_stack_trace_explorer_on_focus" xml:space="preserve"> | ||
| <value>Automatically open Stack Trace Explorer on focus</value> |
There was a problem hiding this comment.
I'm guessing its too long to put "when a stack trace is on the clipboard" on the end here?
There was a problem hiding this comment.
I think so. I wonder where we would put explainers like this. Honestly might be worth a short paragraph below the checkbox explaining the behavior, but I don't think we normally do that.
| /// Returns true if there's a tab that already matches the text | ||
| /// </summary> | ||
| public bool ContainsTab(string text) | ||
| => Tabs.Any(tab => tab.Content.ViewModel.Matches(text)); |
There was a problem hiding this comment.
Is this slow and/or does it need the UI thread? I wonder what the trade off here is, if you have a lot of tabs, versus just keeping the most recent clipboard text seen in memory, and rejecting that.
There was a problem hiding this comment.
It's pretty fast just because it's a hashcode comparison. It doesn't need UI thread as long as the underlying Tabs isn't being modified...
Yea, this was just taken from feedback. We'll see what people think. It's present in the right click menu as well (plus paste) |
TODO: