Skip to content

Clear prior build errors for additional and analyzer config docs at s…#58457

Merged
mavasani merged 1 commit intodotnet:mainfrom
mavasani:RazorBug
Dec 22, 2021
Merged

Clear prior build errors for additional and analyzer config docs at s…#58457
mavasani merged 1 commit intodotnet:mainfrom
mavasani:RazorBug

Conversation

@mavasani
Copy link
Copy Markdown
Contributor

…tart of build

Fixes AB#1424584

The primary issue is that the lingering compiler warning CS0169 from prior solution snapshot is reported in Index.razor, which is an Additional document, not a regular source document. Existing code in clearing build diagnostics at start of a build was only clearing diagnostics with location in source documents. Doing the same for additional documents fixes this issue.

…tart of build

Fixes [AB#1424584](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1424584)

The primary issue is that the lingering compiler warning CS0169 from prior solution snapshot is reported in `Index.razor`, which is an Additional document, not a regular source document. Existing code in clearing build diagnostics at start of a build was only clearing diagnostics with location in source documents. Doing the same for additional documents fixes this issue.
@mavasani mavasani added this to the 17.1 milestone Dec 22, 2021
@mavasani mavasani requested review from a team, NTaylorMullen and dibarbet December 22, 2021 05:26
@mavasani
Copy link
Copy Markdown
Contributor Author

@dibarbet @NTaylorMullen do we have integration tests for razor? If so, I can add a regression test for this scenario.

@NTaylorMullen
Copy link
Copy Markdown

@dibarbet @NTaylorMullen do we have integration tests for razor? If so, I can add a regression test for this scenario.

I'm actually not entirely sure. @dibarbet would know better though

@mavasani
Copy link
Copy Markdown
Contributor Author

Alright, I’ll merge the PR and add a regression test later if feasible.

@mavasani mavasani merged commit 6ea8af0 into dotnet:main Dec 22, 2021
@ghost ghost modified the milestones: 17.1, Next Dec 22, 2021
@mavasani mavasani deleted the RazorBug branch December 22, 2021 16:15
@dibarbet
Copy link
Copy Markdown
Member

dibarbet commented Jan 3, 2022

@dibarbet @NTaylorMullen do we have integration tests for razor? If so, I can add a regression test for this scenario.

I'm actually not entirely sure. @dibarbet would know better though

Unfortunately not - the last time I attempted to go down that path the VM images did not have the required razor templates installed on them. @ryanbrandenburg I think you were recently working on razor integration tests - are the templates available now?

@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants