Report level 7 name warning for record when langversion is below 9#58452
Merged
333fred merged 2 commits intodotnet:mainfrom Dec 28, 2021
Merged
Report level 7 name warning for record when langversion is below 9#58452333fred merged 2 commits intodotnet:mainfrom
record when langversion is below 9#58452333fred merged 2 commits intodotnet:mainfrom
Conversation
Another small bug I noticed when working on required members and touching this function. We currently do not report a level 7 warning for 'record' when the langversion is below the minimum for records.
Member
Author
|
@dotnet/roslyn-compiler for a small review. |
Member
Author
|
@dotnet/roslyn-compiler for a small review. |
jcouv
approved these changes
Dec 27, 2021
Member
jcouv
left a comment
There was a problem hiding this comment.
I'd left the record case intentionally alone but that doesn't make much sense. I agree the warning should apply too. LGTM Thanks (iteration 2)
Member
Author
|
Yeah, my reasoning is that, since the warning is only possibly true for most identifiers, but is definitely true for @dotnet/roslyn-compiler for a second small review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another small bug I noticed when working on required members and touching this function. We currently do not report a level 7 warning for 'record' when the langversion is below the minimum for records.