Skip to content

Remove unused message argument#58432

Merged
333fred merged 1 commit intodotnet:mainfrom
333fred:remove-unused-arg
Dec 21, 2021
Merged

Remove unused message argument#58432
333fred merged 1 commit intodotnet:mainfrom
333fred:remove-unused-arg

Conversation

@333fred
Copy link
Copy Markdown
Member

@333fred 333fred commented Dec 20, 2021

While adjusting this code in the required-members branch I noticed the parameter is unused by the error message, so I did a small refactoring in main to clean that up.

While adjusting this code in the required-members branch I noticed the parameter is unused by the error message, so I did a small refactoring in main to clean that up.
@333fred 333fred requested a review from a team as a code owner December 20, 2021 22:32
@ghost ghost added the Area-Compilers label Dec 20, 2021
Copy link
Copy Markdown
Member

@chsienki chsienki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@333fred
Copy link
Copy Markdown
Member Author

333fred commented Dec 20, 2021

@AlekseyTs could you take a look as well?

Copy link
Copy Markdown
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@333fred 333fred enabled auto-merge (squash) December 20, 2021 23:14
@333fred 333fred merged commit e01c235 into dotnet:main Dec 21, 2021
@ghost ghost added this to the Next milestone Dec 21, 2021
@333fred 333fred deleted the remove-unused-arg branch December 21, 2021 01:16
@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants