Improve error reporting for 'this()' initializer from 'record struct' constructor#58430
Merged
cston merged 1 commit intodotnet:mainfrom Jan 3, 2022
Merged
Improve error reporting for 'this()' initializer from 'record struct' constructor#58430cston merged 1 commit intodotnet:mainfrom
cston merged 1 commit intodotnet:mainfrom
Conversation
AlekseyTs
approved these changes
Dec 20, 2021
Contributor
AlekseyTs
left a comment
There was a problem hiding this comment.
LGTM (commit 1), assuming CI is passing. Consider using more descriptive commit title when merging.
Contributor
Author
|
@dotnet/roslyn-compiler, please review, thanks. |
jcouv
reviewed
Jan 3, 2022
| { | ||
| var constructorSymbol = (MethodSymbol)this.ContainingMember(); | ||
| if (!constructorSymbol.IsStatic && | ||
| if (isInstanceConstructor(out MethodSymbol constructorSymbol) && |
Member
There was a problem hiding this comment.
nit: merge into outer if now that we can?
Contributor
Author
There was a problem hiding this comment.
Let's address separately if necessary.
jcouv
approved these changes
Jan 3, 2022
Member
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks (iteration 1) with a nit to consider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for:
Report error if 'record struct' constructor calls default parameterless constructor #58339