Remove unnecessary assertion that CancellationSeries is disposed#58426
Merged
sharwell merged 1 commit intodotnet:mainfrom Dec 20, 2021
Merged
Remove unnecessary assertion that CancellationSeries is disposed#58426sharwell merged 1 commit intodotnet:mainfrom
sharwell merged 1 commit intodotnet:mainfrom
Conversation
This type functions correctly whether or not it is explicitly disposed.
Member
|
@sharwell Was this breaking something or just general cleanup as you saw it as a part of something else? |
Contributor
Author
|
We have some use cases/paths where this type is not disposed. If you try running local debug bits for extended periods of time, it will eventually crash. |
jasonmalinowski
approved these changes
Dec 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This type functions correctly whether or not it is explicitly disposed.