Move component model code to common location for all AbstractPackages#58397
Merged
CyrusNajmabadi merged 9 commits intodotnet:mainfrom Dec 18, 2021
Merged
Move component model code to common location for all AbstractPackages#58397CyrusNajmabadi merged 9 commits intodotnet:mainfrom
CyrusNajmabadi merged 9 commits intodotnet:mainfrom
Conversation
sharwell
approved these changes
Dec 17, 2021
src/VisualStudio/Core/Def/Implementation/LanguageService/AbstractPackage.cs
Show resolved
Hide resolved
| { | ||
| internal abstract class AbstractPackage : AsyncPackage | ||
| { | ||
| private IComponentModel _componentModel_doNotAccessDirectly; |
Contributor
There was a problem hiding this comment.
💭 Not a huge fan of _doNotAccessDirectly here... but hopefully this can be removed once we can have partial-auto-properties.
…actPackage.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
jasonmalinowski
approved these changes
Dec 18, 2021
|
|
||
| protected override async Task InitializeAsync(CancellationToken cancellationToken, IProgress<ServiceProgressData> progress) | ||
| { | ||
| await JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken); |
Member
There was a problem hiding this comment.
Does this still need to call the base.InitiaizeAsync too?
| { | ||
| internal abstract class AbstractPackage : AsyncPackage | ||
| { | ||
| private IComponentModel _componentModel_doNotAccessDirectly; |
Member
There was a problem hiding this comment.
Want to at least #nullable enable this bit and make the field nullable?
…di/roslyn into shareComponentModel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.