Skip to content

Simplify fault reporting#58367

Merged
jasonmalinowski merged 4 commits intodotnet:release/dev17.1from
jasonmalinowski:simplify-fault-reporting
Jan 6, 2022
Merged

Simplify fault reporting#58367
jasonmalinowski merged 4 commits intodotnet:release/dev17.1from
jasonmalinowski:simplify-fault-reporting

Conversation

@jasonmalinowski
Copy link
Copy Markdown
Member

Individual commits explain logic here.

@jasonmalinowski jasonmalinowski requested a review from a team as a code owner December 16, 2021 02:29
@ghost ghost added the Area-IDE label Dec 16, 2021
@jasonmalinowski jasonmalinowski force-pushed the simplify-fault-reporting branch from f8b7345 to b6936c9 Compare December 16, 2021 02:30
namespace Microsoft.CodeAnalysis.ErrorReporting
{
internal class WatsonTraceListener : TraceListener
internal class TestTraceListener : TraceListener
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to match the other test-specific classes, and "Watson" is a pretty out of date term here since it's not really about that anymore.

@jasonmalinowski jasonmalinowski self-assigned this Dec 16, 2021
Copy link
Copy Markdown
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make no judgement call about the extra info that was sent previously, but the rest of what you said made sense.

No reason it can't just be with the other integration-test-only fault
handlers.
There's a few things this piece of code is trying to do:

1. If we have an aggregate exception, try to update the bucket
   parameters to represent the stuff inside. Rather than doing that
   it's much easier to just do a report for each inner exception, which
   will not interfere with other targeted notification policies.
2. If we have a remote exception, try to bucket on some other
   information. What I don't get is the information there is the stack
   trace (which is the client stack trace) and the message which we'd
   already include anyways -- nothing there is any more actionable
   than just falling into the default error reporting logic.
3. Trying to report inner exceptions over the outer exception if
   ever one exists. I can't say that's a great idea unless we actually
   know the type of exception more directly.

Just deleting this all seems much easier.
@jasonmalinowski jasonmalinowski force-pushed the simplify-fault-reporting branch from b22c60f to ec7e122 Compare January 4, 2022 22:34
@jasonmalinowski jasonmalinowski changed the base branch from main to release/dev17.1 January 5, 2022 19:20
@jinujoseph jinujoseph added this to the 17.1.P3 milestone Jan 5, 2022
@jasonmalinowski jasonmalinowski merged commit d223064 into dotnet:release/dev17.1 Jan 6, 2022
@jasonmalinowski jasonmalinowski deleted the simplify-fault-reporting branch January 6, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants