Simplify fault reporting#58367
Merged
jasonmalinowski merged 4 commits intodotnet:release/dev17.1from Jan 6, 2022
Merged
Conversation
f8b7345 to
b6936c9
Compare
jasonmalinowski
commented
Dec 16, 2021
| namespace Microsoft.CodeAnalysis.ErrorReporting | ||
| { | ||
| internal class WatsonTraceListener : TraceListener | ||
| internal class TestTraceListener : TraceListener |
Member
Author
There was a problem hiding this comment.
Renamed to match the other test-specific classes, and "Watson" is a pretty out of date term here since it's not really about that anymore.
davidwengier
approved these changes
Dec 16, 2021
Member
davidwengier
left a comment
There was a problem hiding this comment.
I can make no judgement call about the extra info that was sent previously, but the rest of what you said made sense.
No reason it can't just be with the other integration-test-only fault handlers.
There's a few things this piece of code is trying to do: 1. If we have an aggregate exception, try to update the bucket parameters to represent the stuff inside. Rather than doing that it's much easier to just do a report for each inner exception, which will not interfere with other targeted notification policies. 2. If we have a remote exception, try to bucket on some other information. What I don't get is the information there is the stack trace (which is the client stack trace) and the message which we'd already include anyways -- nothing there is any more actionable than just falling into the default error reporting logic. 3. Trying to report inner exceptions over the outer exception if ever one exists. I can't say that's a great idea unless we actually know the type of exception more directly. Just deleting this all seems much easier.
b22c60f to
ec7e122
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Individual commits explain logic here.