Do not throw for user paths that contain a quote character in them.#58357
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Dec 16, 2021
Merged
Do not throw for user paths that contain a quote character in them.#58357CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Conversation
ryzngard
approved these changes
Dec 15, 2021
| // Because instantiating the connection will fail, we will not get back | ||
| // a working persistent storage. We are testing a fault recovery code path. | ||
| await using (var storage = await GetStorageAsync(solution, faultInjector, throwOnFailure: false)) | ||
| await using (var storage = await GetStorageAsync(solution, faultInjector: faultInjector, throwOnFailure: false)) |
Contributor
Author
There was a problem hiding this comment.
i added another optional parameter, and this positional one needed to become named.
Member
|
@CyrusNajmabadi does this need to be taken for servicing / backported? Or is 17.1p3 good enough |
Contributor
Author
|
We've lived with it thsi far. I imagine we don't need servicing. (it's just degraded perf, not any other user visible problem) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_queries/edit/1436188