Skip to content

OmniSharp options - take 2#58355

Merged
tmat merged 2 commits intodotnet:mainfrom
tmat:OmniSharpOptions2
Dec 16, 2021
Merged

OmniSharp options - take 2#58355
tmat merged 2 commits intodotnet:mainfrom
tmat:OmniSharpOptions2

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Dec 15, 2021

Redo of #58208:

Further options refactoring focused on options set by OmniSharp.

Adds External Access APIs that allow OmniSharp to specify options directly.

Depends on VS insertion of https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/369132

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Dec 16, 2021

@JoeRobich

@dibarbet
Copy link
Copy Markdown
Member

dibarbet commented Dec 16, 2021

@tmat does this require the TS change to be dual inserted, or just inserted before this one? just confirmed offline, just prior insertion

@tmat tmat merged commit 88f8299 into dotnet:main Dec 16, 2021
@ghost ghost added this to the Next milestone Dec 16, 2021
@tmat tmat deleted the OmniSharpOptions2 branch December 16, 2021 22:02
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Dec 16, 2021

@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
@ryzngard ryzngard added UX Review Not Required UX Review Not Required and removed Needs UX Triage labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants