Check operations when doing type name simplification#58285
Merged
CyrusNajmabadi merged 7 commits intodotnet:mainfrom Dec 14, 2021
Merged
Check operations when doing type name simplification#58285CyrusNajmabadi merged 7 commits intodotnet:mainfrom
CyrusNajmabadi merged 7 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Dec 12, 2021
src/EditorFeatures/VisualBasicTest/SimplifyTypeNames/SimplifyTypeNamesTests.vb
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Dec 12, 2021
| Await TestAsync( | ||
| "Imports System | ||
| [|System.Console.WriteLine(0)|]", | ||
| [|System.Console|].WriteLine(0)", |
Contributor
Author
There was a problem hiding this comment.
old test span was incorrect (but the test still worked because of bugs in the analyzer). With the PR we still offer the fix but on the right span.
…adi/roslyn into speculationOperation
davidwengier
approved these changes
Dec 13, 2021
Member
davidwengier
left a comment
There was a problem hiding this comment.
I in no way understand this (isn't it an instance call before and after, just on the wrong target after the casts were removed?) but I trust that you know what you're doing and the tests pass :D
This was referenced Dec 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57767