Include any class with methods with attributes in RunTests#58259
Merged
RikkiGibson merged 2 commits intomainfrom Dec 11, 2021
Merged
Include any class with methods with attributes in RunTests#58259RikkiGibson merged 2 commits intomainfrom
RikkiGibson merged 2 commits intomainfrom
Conversation
JoeRobich
approved these changes
Dec 10, 2021
Member
Author
|
It turns out that test methods are allowed to have any accessibility and we will still run them. So I think the change in this PR is the right one to make. |
jaredpar
approved these changes
Dec 10, 2021
Member
Author
|
Turns out the tests we weren't running are now failing :) Filed #58263 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the issue where
ExternalAccess.Razortests don't run in CI. RunTests assumed that only public methods could be test methods, but it turns out internal methods can be too.FYI @pawchen @JoeRobich