IDE code generator service refactoring#58244
Merged
tmat merged 19 commits intodotnet:mainfrom Jan 11, 2022
Merged
Conversation
This was referenced Dec 10, 2021
src/Analyzers/CSharp/Analyzers/UseExpressionBody/Helpers/UseExpressionBodyHelper`1.cs
Show resolved
Hide resolved
73e0c5a to
a54548f
Compare
bda74ee to
a839e7e
Compare
a839e7e to
30895e4
Compare
Member
Author
333fred
reviewed
Dec 14, 2021
Member
333fred
left a comment
There was a problem hiding this comment.
Done review pass of the compiler layer (commit 9)
333fred
approved these changes
Dec 14, 2021
Member
333fred
left a comment
There was a problem hiding this comment.
Compiler changes LGTM (commit 9)
src/Analyzers/CSharp/Analyzers/UseExpressionBody/UseExpressionBodyDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/CodeFixes/UseDeconstruction/CSharpUseDeconstructionCodeFixProvider.cs
Show resolved
Hide resolved
...alyzers/Core/CodeFixes/ConvertTypeOfToNameOf/AbstractConvertTypeOfToNameOfCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharp/EventHookup/EventHookupCommandHandler_TabKeyCommand.cs
Show resolved
Hide resolved
src/EditorFeatures/CSharp/EventHookup/EventHookupCommandHandler_TabKeyCommand.cs
Outdated
Show resolved
Hide resolved
...AutoPropertyToFullProperty/CSharpConvertAutoPropertyToFullPropertyCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
.../Portable/UseExpressionBodyForLambda/UseExpressionBodyForLambdaCodeStyleProvider_Analysis.cs
Show resolved
Hide resolved
src/Features/Core/Portable/AddObsoleteAttribute/AbstractAddObsoleteAttributeCodeFixProvider.cs
Show resolved
Hide resolved
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
jcouv
reviewed
Jan 11, 2022
jcouv
reviewed
Jan 11, 2022
RikkiGibson
approved these changes
Jan 11, 2022
| SyntaxToken identifier, | ||
| ParameterListSyntax parameterList, | ||
| ConstructorInitializerSyntax initializer, | ||
| ConstructorInitializerSyntax? initializer, |
Member
There was a problem hiding this comment.
part of me wonders if we can run some check to ensure that nullability of these kinds of factory methods remains synchronized with the nullability in Syntax.xml. #Closed
jcouv
approved these changes
Jan 11, 2022
Member
jcouv
left a comment
There was a problem hiding this comment.
Compiler changes LGTM Thanks (iteration 19)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds nullable annotations to code generation sources.
Adds missing cancellation tokens to call sites.
Separates options passed thru code gen code into document/language-specific (
CodeGenerationPreferences) and operation specific (CodeGenerationContext).Flow document-specific options thru from the document that code generator generates into. Previously, in some cases we passed no options to the code gen apis and the implementation read them from Workspace.Options. The workspace options do not have editorconfig options applied to specific documents.
Review strategy: commits can be reviewed individually.