Avoid loading analyzers during unload#58240
Merged
jasonmalinowski merged 1 commit intodotnet:mainfrom Dec 10, 2021
Merged
Conversation
AnalyzerFileReferences won't actually load their assembly until needed; 359f24a fixed the fact we weren't disposing our type that produces AnalyzerFileReferences, but in the process that became another place we'd load the analyzers if they hadn't already been needed. We have some internal performance tests that actually never needed them until close, so this would trigger a load.
JoeRobich
approved these changes
Dec 10, 2021
Therzok
approved these changes
Dec 10, 2021
CyrusNajmabadi
approved these changes
Dec 10, 2021
Member
Author
|
Merged without rerunning the flaky integration test leg; we had a private RPS run that confirms that this is fixing the regression so it's important to unblock that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnalyzerFileReferences won't actually load their assembly until needed; 359f24a fixed the fact we weren't disposing our type that produces AnalyzerFileReferences, but in the process that became another place we'd load the analyzers if they hadn't already been needed. We have some internal performance tests that actually never needed them until close, so this would trigger a load.