Skip to content

NullableWalker - properly handle BoundNoPiaObjectCreationExpression#58227

Merged
AlekseyTs merged 1 commit intodotnet:mainfrom
AlekseyTs:Issue45082
Dec 10, 2021
Merged

NullableWalker - properly handle BoundNoPiaObjectCreationExpression#58227
AlekseyTs merged 1 commit intodotnet:mainfrom
AlekseyTs:Issue45082

Conversation

@AlekseyTs
Copy link
Copy Markdown
Contributor

@AlekseyTs AlekseyTs commented Dec 9, 2021

Fixes #45082.
Closes #56863.

@AlekseyTs AlekseyTs requested review from a team and 333fred December 9, 2021 22:23
333fred
333fred approved these changes Dec 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@AlekseyTs
Copy link
Copy Markdown
Contributor Author

AlekseyTs commented Dec 10, 2021

@dotnet/roslyn-compiler For the second review.

@AlekseyTs AlekseyTs merged commit 709d483 into dotnet:main Dec 10, 2021
@ghost ghost added this to the Next milestone Dec 10, 2021
@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@333fred 333fred 333fred approved these changes

+1 more reviewer

@cston cston cston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Compilers Feature - Nullable Reference Types Nullable Reference Types

Projects

None yet

Milestone

17.1.P3

4 participants

@AlekseyTs @333fred @cston @Cosifne