Remove usage of weak-value-source for smart-open-scope references#58212
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Dec 10, 2021
Merged
Remove usage of weak-value-source for smart-open-scope references#58212CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
Conversation
dibarbet
approved these changes
Dec 9, 2021
sharwell
reviewed
Dec 9, 2021
| { | ||
| var temporaryStorage = workspaceServices.GetService<ITemporaryStorageService>(); | ||
| Interlocked.CompareExchange(ref _singleton, new VisualStudioMetadataReferenceManager(workspaceServices.Workspace, _serviceProvider, temporaryStorage), null); | ||
| Interlocked.CompareExchange(ref _singleton, new VisualStudioMetadataReferenceManager(_serviceProvider, temporaryStorage), null); |
Contributor
There was a problem hiding this comment.
❗ This incorrectly provides a VisualStudioMetadataReferenceManager using the ITemporaryStorageService from an unrelated workspace. The cache field needs to be removed.
Contributor
There was a problem hiding this comment.
This bug isn't introduced by this pull request, but if you aren't fixing it here please file a bug for the 17.1 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A/B testing (2000 people in each group) revealed no interesting change from just turning this off. My theory here is that for projecs that reference dlls from standard runtime locations, there is very little removal of said dlls, and the compiler ends up rooting all these assemblies anyways through any metadata symbols we have.
Also, because we are using the open-scope-system, the platform effectively does hteir memory mapping once and keeps that memory around forever (in case other components need it, or roslyn needs it again). So that is also effectively a fixed cost that won't ever be given back.