Update Microsoft.CodeAnalysis.Analyzers to 3.3.3#58154
Conversation
|
@333fred In your comment (dotnet/roslyn-analyzers#5246 (comment)), were you hitting the issue in roslyn repo or outside? If in roslyn, can you confirm this fixes it? |
eng/Versions.props
Outdated
| <PropertyGroup> | ||
| <!-- Versions used by several individual references below --> | ||
| <RoslynDiagnosticsNugetPackageVersion>3.3.3-beta1.21105.3</RoslynDiagnosticsNugetPackageVersion> | ||
| <RoslynDiagnosticsNugetPackageVersion>3.3.3</RoslynDiagnosticsNugetPackageVersion> |
There was a problem hiding this comment.
This property is used for two packages:
- Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers
- Roslyn.Diagnostics.Analyzers
PerformanceSensitiveAnalyzers doesn't have a 3.3.3 version. The version specified for those two packages should be separated.
Filed #58159.
.editorconfig
Outdated
|
|
||
| # RS1034: Prefer 'IsKind' for checking syntax kinds | ||
| # Hold on https://github.com/dotnet/roslyn/pull/51823#pullrequestreview-612747491 | ||
| dotnet_diagnostic.RS1034.severity = none |
There was a problem hiding this comment.
❗ Use .globalconfig instead of .editorconfig for disabling rules (the latter requires evaluating the severity condition for every syntax tree in the solution, instead of just once). Roslyn's global configuration files are here:
https://github.com/dotnet/roslyn/tree/main/eng/config/globalconfigs
📝 Some rules currently violate this. You only need to update this (the new) severity configuration. The rest can stay as they currently are.
Outside the repo, but I did confirm that 3.3.3 fixed the issue. |
3.3.2 has a bug that's being reported a lot. Updating the dependency to 3.3.3.