Skip to content

Update publishdata.json to point to correct VS branch#58142

Merged
JoeRobich merged 2 commits intomainfrom
dibarbet-update-17-1
Dec 7, 2021
Merged

Update publishdata.json to point to correct VS branch#58142
JoeRobich merged 2 commits intomainfrom
dibarbet-update-17-1

Conversation

@dibarbet
Copy link
Copy Markdown
Member

@dibarbet dibarbet commented Dec 6, 2021

No description provided.

@dibarbet dibarbet requested a review from a team as a code owner December 6, 2021 23:08
"version": "4.1.*",
"packageFeeds": "default",
"channels": [],
"vsBranch": "main",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should target Roslyn's release/dev17.1 branch instead of main

Copy link
Copy Markdown
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retarget this PR to our 17.1 P2 branch

@dibarbet
Copy link
Copy Markdown
Member Author

dibarbet commented Dec 6, 2021

@ryzngard I believe publishdata.json is always read from main (unless it has changed recently)

publishDataURI: "https://dev.azure.com/dnceng/internal/_apis/git/repositories/dotnet-roslyn/items?path=eng/config/PublishData.json&api-version=6.0"

@JoeRobich JoeRobich dismissed ryzngard’s stale review December 6, 2021 23:19

PublishData.json is always read from the main branch.

@JoeRobich
Copy link
Copy Markdown
Member

@dibarbet should we also update main-vs-deps to not create draft PRs?

@dibarbet
Copy link
Copy Markdown
Member Author

dibarbet commented Dec 6, 2021

@dibarbet should we also update main-vs-deps to not create draft PRs?

good call, updating

@JoeRobich JoeRobich merged commit 6d4f1fe into main Dec 7, 2021
@ghost ghost added this to the Next milestone Dec 7, 2021
@dibarbet dibarbet deleted the dibarbet-update-17-1 branch December 7, 2021 19:13
@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants