Skip to content

Use ldlen to get array's Length during pattern-matching.#58114

Merged
AlekseyTs merged 2 commits intodotnet:mainfrom
AlekseyTs:Issue57728
Dec 7, 2021
Merged

Use ldlen to get array's Length during pattern-matching.#58114
AlekseyTs merged 2 commits intodotnet:mainfrom
AlekseyTs:Issue57728

Conversation

@AlekseyTs
Copy link
Copy Markdown
Contributor

Fixes #56199.
Fixes #57728.

@AlekseyTs
Copy link
Copy Markdown
Contributor Author

@dotnet/roslyn-compiler Please review.

@jcouv jcouv added this to the 17.1 milestone Dec 4, 2021
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks! (iteration 1)

@AlekseyTs
Copy link
Copy Markdown
Contributor Author

@dotnet/roslyn-compiler For the second review.

@AlekseyTs
Copy link
Copy Markdown
Contributor Author

@dotnet/roslyn-compiler For the second review.

1 similar comment
@AlekseyTs
Copy link
Copy Markdown
Contributor Author

@dotnet/roslyn-compiler For the second review.

@AlekseyTs AlekseyTs merged commit 372e451 into dotnet:main Dec 7, 2021
@ghost ghost modified the milestones: 17.1, Next Dec 7, 2021
@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected IL for a list pattern over an array Emit ldlen in pattern matching on arrays

4 participants