Port CSharpCodeActions and CSharpFindReferences to the new test harness#58037
Merged
sharwell merged 13 commits intodotnet:mainfrom Jan 20, 2022
Merged
Port CSharpCodeActions and CSharpFindReferences to the new test harness#58037sharwell merged 13 commits intodotnet:mainfrom
sharwell merged 13 commits intodotnet:mainfrom
Conversation
sharwell
commented
Nov 30, 2021
| if (!RoslynString.IsNullOrEmpty(applyFix)) | ||
| { | ||
| var codeActionLogger = new CodeActionLogger(); | ||
| using var loggerRestorer = WithLogger(AggregateLogger.AddOrReplace(codeActionLogger, Logger.GetLogger(), logger => logger is CodeActionLogger)); |
Contributor
Author
There was a problem hiding this comment.
@mavasani WithWorkspaceChangedHandler and WithLogger are much more difficult to implement in the old test harness. These handlers should provide much better data about operations that lead to code action application failure.
267785a to
83ffbb3
Compare
8daad47 to
da70a9d
Compare
This was referenced Dec 2, 2021
7921251 to
6289a26
Compare
6289a26 to
e0233ed
Compare
sharwell
commented
Dec 7, 2021
src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpCodeActions.cs
Outdated
Show resolved
Hide resolved
e0233ed to
22d5f34
Compare
JoeRobich
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.